On Thu, Feb 05, 2026 at 12:26:40AM -0800, Shameer Kolothum Thodi wrote: > > > > -----Original Message----- > > From: Nicolin Chen <[email protected]> > > Sent: 04 February 2026 19:55 > > To: Shameer Kolothum Thodi <[email protected]> > > Cc: [email protected]; [email protected]; > > [email protected]; [email protected]; Nathan Chen > > <[email protected]>; Matt Ochs <[email protected]>; Jason Gunthorpe > > <[email protected]>; [email protected]; > > [email protected]; [email protected]; Krishnakant Jaju > > <[email protected]> > > Subject: Re: [PATCH v4 3/5] hw/arm/smmuv3-accel: Allocate vEVENTQ for > > accelerated SMMUv3 devices > > > > On Wed, Feb 04, 2026 at 07:00:06PM +0000, Shameer Kolothum wrote: > > > +bool smmuv3_accel_alloc_veventq(SMMUv3State *s, Error **errp) { > > > + SMMUv3AccelState *accel = s->s_accel; > > > + IOMMUFDVeventq *veventq; > > > + uint32_t veventq_id; > > > + uint32_t veventq_fd; > > > + > > > + if (!accel->viommu) { > > > + return true; > > > + } > > > > This seems meaningless or should be an assert? > > Hmm.. We need this check because, if there are no cold-plugged devices, > when the guest boots and enables EventQ, the vIOMMU may not exist yet. > > Isn't it?
Oh, you are right. I missed the other call in smmu_writel(). Nicolin
