On Fri, Feb 06, 2026 at 02:48:21PM +0000, Shameer Kolothum wrote: > Add an "identifier" property to the SMMUv3 device and use it when > building the ACPI IORT SMMUv3 node Identifier field. > > This avoids relying on enumeration order and provides a stable > per-device identifier. This is useful when we add support for > Tegra241 CMDQV DSDT in subsequent patch. > > No functional change intended. > > Signed-off-by: Shameer Kolothum <[email protected]>
Reviewed-by: Nicolin Chen <[email protected]> With nits: > diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c > index 7858bf2c33..7f84c87a46 100644 > --- a/hw/arm/smmuv3.c > +++ b/hw/arm/smmuv3.c > @@ -2114,6 +2114,7 @@ static const Property smmuv3_properties[] = { > * Defaults to stage 1 > */ > DEFINE_PROP_STRING("stage", SMMUv3State, stage), > + DEFINE_PROP_UINT8("identifier", SMMUv3State, identifier, 0), Perhaps add a line of comments for where we use it. > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 390845c503..22ee5c4a41 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -3059,12 +3059,15 @@ static void > virt_machine_device_pre_plug_cb(HotplugHandler *hotplug_dev, > (vms->legacy_smmuv3_present) ? > "iommu=smmuv3" : "virtio-iommu"); > } else if (vms->iommu == VIRT_IOMMU_NONE) { > + static uint8_t id; Local static feels odd. Perhaps make it global?
