> -----Original Message-----
> From: Eric Auger <[email protected]>
> Sent: 12 February 2026 18:30
> To: Shameer Kolothum Thodi <[email protected]>; qemu-
> [email protected]; [email protected]
> Cc: [email protected]; [email protected]; [email protected]; Nicolin
> Chen <[email protected]>; Nathan Chen <[email protected]>; Matt
> Ochs <[email protected]>; Jiandi An <[email protected]>; Jason Gunthorpe
> <[email protected]>; [email protected];
> [email protected]; [email protected]; Krishnakant Jaju
> <[email protected]>
> Subject: Re: [PATCH v2 22/24] hw/arm/smmuv3: Add per-device identifier
> poroperty
> 
> External email: Use caution opening links or attachments
> 
> 
> On 2/6/26 3:48 PM, Shameer Kolothum wrote:
> > Add an "identifier" property to the SMMUv3 device and use it when
> > building the ACPI IORT SMMUv3 node Identifier field.
> >
> > This avoids relying on enumeration order and provides a stable
> > per-device identifier. This is useful when we add support for
> > Tegra241 CMDQV DSDT in subsequent patch.
> >
> > No functional change intended.
> I think an important info which is missing here is you need the id used
> in IORT and DSDT to be the same, is that correct

Yes. That is correct. I think I have that explanation in next patch. I will
mention it here as well.
> 
> By the way why can't you reuse the QOM id. I think Dan said there is one
> for all QOM objects.

Yes. QOM device has a global id. But I am not sure we can use that here.
For one it is a "char *" and normally user or management layers will use
That,
eg:
-device arm-smmuv3,primary-bus=pcie.1,id=smmuv3.1-pxb1,

Thanks,
Shameer

Reply via email to