Am 17.06.2012 20:46, schrieb Anthony Liguori: > On 06/17/2012 12:00 PM, Andreas Färber wrote: >> Am 17.06.2012 18:23, schrieb Andreas Färber: >>> I've tested with just >>> +$(eval -include $(wildcard $1/*.d)) >>> and did >>> $ touch include/qemu/object.h >>> >>> From what I see, using Anthony's original patch plus the modification >>> above (not the other ones), {i386,x86_64}-softmmu/hw/kvm/apic.o is still >>> not getting rebuilt despite its included hw/apic_internal.h depending on >>> sysbus.h -> qdev.h -> qemu/object.h. >>> >>> They're being added via obj-$(CONFIG_KVM) += kvm/filename.o, not via the >>> recursive directory rule, so are not caught by Anthony's rule. >>> >>> Maybe fix by some explicit Makefile-specific rule such as this? >>> >>> diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs >>> index d43f1df..1e8423a 100644 >>> --- a/hw/i386/Makefile.objs >>> +++ b/hw/i386/Makefile.objs >>> @@ -11,3 +11,5 @@ obj-$(CONFIG_KVM) += kvm/clock.o kvm/apic.o >>> kvm/i8259.o kvm/ioapic.o kvm/i8254.o >>> obj-$(CONFIG_SPICE) += qxl.o qxl-logger.o qxl-render.o >>> >>> obj-y := $(addprefix ../,$(obj-y)) >>> + >>> +-include $(wildcard ../kvm/*.d) >> >> If using hw/kvm/*.d instead, it actually works. ;) > > We can also just add a hw/kvm/Makefile.objs and then add kvm/ to the > subdir rules. Seems to fix the problem you identified.
No, that would be wrong wrt ppc/s390/arm. But we could move the files from hw/kvm/ to hw/i386/. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg