On 06/17/2012 02:53 PM, Andreas Färber wrote:
Am 17.06.2012 20:46, schrieb Anthony Liguori:
On 06/17/2012 12:00 PM, Andreas Färber wrote:
If using hw/kvm/*.d instead, it actually works. ;)
We can also just add a hw/kvm/Makefile.objs and then add kvm/ to the
subdir rules. Seems to fix the problem you identified.
No, that would be wrong wrt ppc/s390/arm. But we could move the files
from hw/kvm/ to hw/i386/.
Hrm, no, I don't think that's necessary.
Look at v2 of my patch. kvm/ is only added by target hw makefiles
(hw/i386/Makefile.objs). So these devices are only even attempted to be added
for i386.
Then within kvm/Makefile.objs, everything is guarded with CONFIG_KVM.
I think a better approach would be to:
hw/Makefiles.obj:
obj-$(CONFIG_KVM) += kvm/
hw/kvm/Makefiles.obj:
obj-$(CONFIG_I386) += apic.o pit.o ...
That way there could be ppc-specific KVM devices.
But that's a bigger refactoring as these devices need to be built
target-specific.
Regards,
Anthony Liguori
Andreas
