On 19/2/26 18:18, Alex Bennée wrote:
Implement a proper cpu reset handler for tricore cpus.

Message-ID: <[email protected]>
Signed-off-by: Alex Bennée <[email protected]>
---
  target/tricore/cpu.c | 9 ++++++++-
  1 file changed, 8 insertions(+), 1 deletion(-)


  static bool tricore_cpu_has_work(CPUState *cs)
  {
      return true;
@@ -120,8 +127,8 @@ static void tricore_cpu_realizefn(DeviceState *dev, Error 
**errp)
      if (tricore_has_feature(env, TRICORE_FEATURE_131)) {
          set_feature(env, TRICORE_FEATURE_13);
      }
-    cpu_reset(cs);
      qemu_init_vcpu(cs);
+    qemu_register_reset(tricore_cpu_reset, cs);

Per commit 9f1c70a2543 ("hw/core: Add documentation and license comments
to reset.h"):

"In general this function should not be used in new code where possible"

Shouldn't we use qemu_register_resettable()?

Reply via email to