On Thu, 19 Feb 2026 at 17:18, Alex Bennée <[email protected]> wrote:
>
> We already have do_cpu_reset called when the system is reset so there
> is no need to do it here.
>
> By removing this we now only do (smp*2)-1 calls to cpu_reset. Once per
> core as part of qemu_system_reset and then once per secondary core as
> PSCI calls are made to reset them.
>
> Message-ID: <[email protected]>
> Signed-off-by: Alex Bennée <[email protected]>
> ---
>  target/arm/cpu.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/target/arm/cpu.c b/target/arm/cpu.c
> index 10f8280eef2..dadc48e06e5 100644
> --- a/target/arm/cpu.c
> +++ b/target/arm/cpu.c
> @@ -2198,7 +2198,6 @@ static void arm_cpu_realizefn(DeviceState *dev, Error 
> **errp)
>      }
>
>      qemu_init_vcpu(cs);
> -    cpu_reset(cs);
>
>      acc->parent_realize(dev, errp);
>  }

Reviewed-by: Peter Maydell <[email protected]>

though it would not surprise me if there was some obscure ordering
requirement that we run into by removing this. I guess we'll have
to wait for the bug reports :-)

thanks
-- PMM

Reply via email to