Hi, Markus.
On 2/24/26 13:02, Markus Armbruster wrote:
Sergei Heifetz<[email protected]> writes:
When QEMU is configured with `--disable-audio`, do not build any
audio-related sources.
[...]
You compile out just the command, and keep all the audio types.
According to the cover letter: "In [certain] environments it is
generally beneficial to avoid building unused code, for both security
and maintenance reasons." True. But if we still need the audio types,
could there be more code we'd rather not build?
To find out, I emptied out qapi/audio.json completely, then fixed what
broke without regard for neatness. Diff appended.
I'm not demanding anything here. I merely want to show where audio
stuff is still used, so we can make an informed decision on where
exactly to make the cut.
Indeed, it was a question of where to draw the line, and my main goal
was to remove the audio/* files. However, I think it’s great that we can
remove qapi/audio.json entirely. Thank you very much for the suggestion
— I’ll try to incorporate it in the next version of the series.
[...]
