On Thu, 26 Feb 2026 at 11:16, Daniel P. BerrangĂ© <[email protected]> wrote:
>
> On Thu, Feb 26, 2026 at 10:44:58AM +0000, Peter Maydell wrote:
> > I'm guessing this is because:
> >  * the coverity job runs on the amd64-fedora-container
> >  * we just upgraded our Fedora container to F43
> >  * coverity configures with --enable-libnfs
>
> Do we really need to be hardcoding configure options ?
>
> It is a pretty random subset of options, compared to what gets
> enabled in the build.

The comment in scripts/coverity-scan/run-coverity-scan gives the
rationale:

# We configure with a fixed set of enables here to ensure that we don't
# accidentally reduce the scope of the analysis by doing the build on
# the system that's missing a dependency that we need to build part of
# the codebase.

And indeed this thread shows that it worked -- without the
--enable-libnfs we would simply not have noticed that we'd
silently stopped scanning block/nfs.c. Now we get to make an
active decision that we're OK with that.

thanks
-- PMM

Reply via email to