On Sun, Mar 01, 2026 at 08:33:15PM +0800, Tao Tang wrote:
> Hi Mostafa,
>
> On 2026/2/27 PM10:49, Mostafa Saleh wrote:
> > On Sat, Feb 21, 2026 at 06:17:33PM +0800, Tao Tang wrote:
> > > Add a STAGE1_SUPPORTED check in the CMD_CFGI_CD and CMD_CFGI_CD_ALL path
> > > and return CERROR_ILL when stage-1 translation is not implemented,
> > > matching the architecture requirement (IHI 0070G.b, page 176).
> > >
> > > Fixes: 32cfd7f39e08 ("hw/arm/smmuv3: Cache/invalidate config data")
> > > Signed-off-by: Tao Tang<[email protected]>
> > This is a separate fix, it can be sent standalone to make this series
> > smaller, similarly the first patch.
>
>
> For #1, #2 and #19 commit (this one), since I’m not fully sure about the
> expected process here, should I resend these already Reviewed-by fixes as
> standalone patch respectively right now, and try to get them merged first?
>
Yes, that's my own opinion, that would make this series smaller and
slightly easier to review, but it's up to Eric.
Thanks,
Mostafa
>
> > Also the "Fixes" comment is not accurate, that was probably broken from
> > the stage-2 implementation which was added later.
>
>
> I'll remove "Fixes" when resending this commit.
>
>
> > Reviewed-by: Mostafa Saleh<[email protected]>
> >
> > Thanks,
> > Mostafa
>
>
> Thanks for your review.
>
> Tao
>
>
