On Mon, 2 Mar 2026 at 22:03, Bernhard Beschow <[email protected]> wrote:
>
> CONFIG_SERIAL selects the internal TYPE_SERIAL device which is akin to
> an "IP block" that needs to be integrated with glue logic. In case of
> NPCM8XX this glue logic is TYPE_SERIAL_MM which the code uses already.
> Fix Kconfig to select CONFIG_SERIAL_MM which matches TYPE_SERIAL_MM.
>
> Fixes: ae0c4d1a1290 ("hw/arm: Add NPCM8XX SoC")
> Signed-off-by: Bernhard Beschow <[email protected]>
> ---
>  hw/arm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index c66c452737..20e99e52b1 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -493,7 +493,7 @@ config NPCM8XX
>      select SMBUS
>      select PL310  # cache controller
>      select NPCM7XX
> -    select SERIAL
> +    select SERIAL_MM
>      select SSI
>      select UNIMP

Reviewed-by: Peter Maydell <[email protected]>

thanks
-- PMM

Reply via email to