On Mon, 2 Mar 2026 at 22:03, Bernhard Beschow <[email protected]> wrote: > > There is no "is_load" flag and one can tell from the method name what > the method does. Remove this unhelpful comment. > > Signed-off-by: Bernhard Beschow <[email protected]> > --- > hw/char/serial.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/hw/char/serial.c b/hw/char/serial.c > index 2c558cb9fc..f73de1ae4f 100644 > --- a/hw/char/serial.c > +++ b/hw/char/serial.c > @@ -281,9 +281,6 @@ static void serial_xmit(SerialState *s) > s->lsr |= UART_LSR_TEMT; > } > > -/* Setter for FCR. > - is_load flag means, that value is set while loading VM state > - and interrupt should not be invoked */ > static void serial_write_fcr(SerialState *s, uint8_t val) > { > /* Set fcr - val only has the bits that are supposed to "stick" */
This must be an ancient stale comment from before the device was converted to vmstate. Reviewed-by: Peter Maydell <[email protected]> thanks -- PMM
