On Thu, 12 Mar 2026 at 14:23, Jonathan Cameron
<[email protected]> wrote:
>
> On Mon, 23 Feb 2026 17:02:08 +0000
> Peter Maydell <[email protected]> wrote:
> > +    /*
> > +     * "reg-names" describes the frames whose address/size is in "reg";
> > +     * at the moment we have only the NS config register frame.
> > +     */
> > +    qemu_fdt_setprop_string(ms->fdt, irsnodename, "reg-names", 
> > "ns-config");
> Don't really care, but you could keep these ordered as per the binding doc
> to make review a tiny little bit easier.  reg comes before reg-names.

I think it would be better to reverse the order in the binding doc :-)
"reg-names" defines what "regs" means, so the values in "regs" are meaningless
until you know what order they're in. So you want to read the reg-names
first, which then allows you to say "yes, the regs values match that".

-- PMM

Reply via email to