From: Ani Sinha <[email protected]> Currently the code that adds a migration blocker does not check if the same blocker already exists. Assert that the migration handler being added has not been added already.
CC: Markus Armbruster <[email protected]> CC: Peter Xu <[email protected]> CC: Prasad Pandit <[email protected]> Reviewed-by: Peter Xu <[email protected]> Signed-off-by: Ani Sinha <[email protected]> Link: https://lore.kernel.org/qemu-devel/[email protected] Signed-off-by: Fabiano Rosas <[email protected]> --- migration/migration.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migration/migration.c b/migration/migration.c index c77832f851..7feeba804f 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -1699,6 +1699,8 @@ static int add_blockers(Error **reasonp, unsigned modes, Error **errp) { for (MigMode mode = 0; mode < MIG_MODE__MAX; mode++) { if (modes & BIT(mode)) { + assert(g_slist_index(migration_blockers[mode], + *reasonp) == -1); migration_blockers[mode] = g_slist_prepend(migration_blockers[mode], *reasonp); } -- 2.51.0
