The string was being dup'ed only to get around the const of the qdict_get_str() return value.
Reviewed-by: Peter Xu <[email protected]> Reviewed-by: Prasad Pandit <[email protected]> Link: https://lore.kernel.org/qemu-devel/[email protected] Signed-off-by: Fabiano Rosas <[email protected]> --- tests/qtest/migration/cpr-tests.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/qtest/migration/cpr-tests.c b/tests/qtest/migration/cpr-tests.c index 0d97b5b89f..63ca5f3996 100644 --- a/tests/qtest/migration/cpr-tests.c +++ b/tests/qtest/migration/cpr-tests.c @@ -154,15 +154,16 @@ static void set_cpr_exec_args(QTestState *who, MigrateCommon *args) static void wait_for_migration_event(QTestState *who, const char *waitfor) { QDict *rsp, *data; - char *status; bool done = false; while (!done) { + const char *status; + rsp = qtest_qmp_eventwait_ref(who, "MIGRATION"); g_assert(qdict_haskey(rsp, "data")); data = qdict_get_qdict(rsp, "data"); g_assert(qdict_haskey(data, "status")); - status = g_strdup(qdict_get_str(data, "status")); + status = qdict_get_str(data, "status"); g_assert(strcmp(status, "failed")); done = !strcmp(status, waitfor); qobject_unref(rsp); -- 2.51.0
