On Fri, Mar 27, 2026 at 7:03 PM Peter Maydell <[email protected]> wrote:
> On Tue, 17 Mar 2026 at 09:48, Peter Maydell <[email protected]> > wrote: > > > > This patchset fixes some issues with the fsfreeze-hook guest-agent > > script reported in > https://gitlab.com/qemu-project/qemu/-/work_items/3339 > > > > * the script is a #!/bin/sh one, but it uses various bash-isms. > > Most are easy fixes, but getting rid of the PIPESTATUS usage > > is a little less obvious, so that gets its own patch > > * a bug in the logic determining whether to log to file or syslog > > means that if the logfile doesn't exist on first run, the script > > will create the logfile but log to syslog (and then log to file > > on second and subsequent runs) > > > > NB: I have tested this by setting up the script and running it > > manually in a temp directory, but not as a "real world" fsfreeze. > > These have been reviewed, do you plan to take them into a pullreq ? > Yes. I keep it for comments from other people. Do you prefer to merge it into v11.0 or v11.1? > > thanks > -- PMM > >
