Am 27.06.2012 15:13, schrieb Li Zhang: > On Wed, Jun 27, 2012 at 8:00 PM, Andreas Färber <afaer...@suse.de> wrote: >> Am 18.06.2012 11:22, schrieb Li Zhang: >>> + bool usb_on = false; >> >> Didn't you want this to be true for sPAPR in absence of -machine? >> > It is set in the following: > > if (machine_opts) > usb_on = qemu_opt_get_bool(machine_opts, "usb", true); > > It means that when using "-machine" option, usb_on is set as true if > usb option is not specified.
What I mean is: -machine usb=on => usb_on == true -machine usb=off => usb_on == false -machine => usb_on == true (nothing) => usb_on == false <-- this !machine_opts case There you should assign true as default, false will be assigned only from qemu_opt_get_bool(). >> Other than that looking good to me now. Where's 2/2? > 2/2's title is as the following: > [Qemu-devel][PATCH 2/2] spapr: Add support for -vga option. :) Please thread the messages together then when sending out the next version. :) /-F -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
