Hi, This is a follow-up to the series [0] that introduces support for resolving 'auto' for arm-smmuv3 accelerated mode's ATS, RIL, SSIDSIZE, and OAS feature properties based on host IOMMU capabilities. This is dependent on the series [1] for changing these property types to accept 'auto' values.
Accelerated SMMUv3 Address Translation Services support is derived from IDR0, Range Invalidation support is derived from IDR3, Substream ID size is derived from IDR1, and output address space is derived from IDR5. The default values are set to 'auto' for all properties. If accel=off and the values are set to 'auto' or are omitted and resolve to 'auto', the default property values defined in smmuv3_init_id_regs() for OAS and RIL will remain unchanged, while SSIDSIZE and ATS values will remain initialized at 0. A complete branch can be found here: https://github.com/NathanChenNVIDIA/qemu/tree/smmuv3-accel-auto-resolve-v3 Please take a look and let me know your feedback. Thanks, Nathan [0] https://lore.kernel.org/all/[email protected]/ [1] https://lore.kernel.org/qemu-arm/[email protected]/ Changes from v2: - Added R-by tags, thanks Eric, Shameer, Cédric for the feedback! - Re-worded descriptions in qemu-options.hx and smmu_validate_property() - Emphasize accel=off auto behavior in a comment for smmuv3_properties[] Changes from v1: - Update qemu-options.hx to explicitly mention auto is supported - Update qemu-options.hx to mention auto as default - Simplify comments in smmuv3_accel_auto_finalise() - Update descriptions in smmuv3_class_init() - Consolidate all default value change patches into one patch - Implement and use smmuv3_pasid_supported() for setting PASID support flag - Move smmuv3_machine_done() and qemu_add_machine_init_done_notifier() to smmuv3-accel.c - Register machine done notifier only in case auto_mode is set Nathan Chen (7): hw/arm/smmuv3-accel: Add helper for resolving auto parameters hw/arm/smmuv3-accel: Implement "auto" value for "ats" hw/arm/smmuv3-accel: Implement "auto" value for "ril" hw/arm/smmuv3-accel: Implement "auto" value for "ssidsize" hw/arm/smmuv3-accel: Implement "auto" value for "oas" hw/arm/smmuv3: Set default ats, ril, ssidsize, oas to auto qemu-options.hx: Support "auto" for accel SMMUv3 properties hw/arm/smmuv3-accel.c | 81 ++++++++++++++++++++++++++++++++++++++++- hw/arm/smmuv3-accel.h | 2 + hw/arm/smmuv3.c | 71 +++++++++++++++++++----------------- hw/core/machine.c | 5 +++ include/hw/arm/smmuv3.h | 2 + qemu-options.hx | 25 ++++++++++--- 6 files changed, 145 insertions(+), 41 deletions(-) -- 2.43.0
