On 5/16/2026 12:15 PM, Philippe Mathieu-Daudé wrote:
> Emphasize the IDAU interface is restricted to TCG by moving the
> header under target/arm/tcg/. Move the definition to cpu-v7m.c
> which also contains v7/v8 hardware (NVIC), keeping only CPU types
> in cpu32.c.
> 
> Reviewed-by: Pierrick Bouvier <[email protected]>
> Reviewed-by: Manos Pitsidianakis <[email protected]>
> Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
> ---
>  include/hw/arm/armv7m.h     |  2 +-
>  include/hw/misc/tz-msc.h    |  2 +-
>  target/arm/{ => tcg}/idau.h |  4 ++--
>  hw/arm/armv7m.c             |  2 +-
>  target/arm/cpu.c            |  2 +-
>  target/arm/ptw.c            |  2 +-
>  target/arm/tcg/cpu-v7m.c    | 11 +++++++++++
>  target/arm/tcg/cpu32.c      |  8 --------
>  8 files changed, 18 insertions(+), 15 deletions(-)
>  rename target/arm/{ => tcg}/idau.h (97%)
> 

This patch creates a problem with the (now merged) commit:
8d3e31c0d575b3265ae5cacfba10680718ba5a22
"target/arm: Extract IDAU interface to its own unit"

Indeed, it results with TYPE_IDAU_INTERFACE being register twice which
fails at startup.

Maybe simply drop current commit?

Regards,
Pierrick

Reply via email to