> -----Original Message----- > From: Philippe Mathieu-Daudé <[email protected]> > Sent: 20 May 2026 03:24 > To: Gaurav Sharma <[email protected]>; [email protected] > Cc: [email protected]; [email protected]; [email protected] > Subject: [EXT] Re: [PATCHv1 4/7] hw/misc: Add MU (Messaging Unit) IP to > i.MX8MP device model > > Caution: This is an external email. Please take care when clicking links or > opening attachments. When in doubt, report the message using the 'Report > this email' button > > > On 19/5/26 19:56, Gaurav Sharma wrote: > > Add emulation of the Messaging Unit and wire it into the i.MX8MP SoC > > model. The MU provides inter-processor communication between the > > Cortex-A53 and Cortex-M7 cores on the i.MX8MP SoC. It is used by the > > Linux remoteproc framework as a mailbox for lifecycle management and > > message passing with the > > Cortex-M7 in an AMP configuration. > > > > Signed-off-by: Gaurav Sharma <[email protected]> > > --- > > docs/system/arm/imx8m.rst | 1 + > > hw/arm/Kconfig | 1 + > > hw/arm/fsl-imx8mp.c | 39 +++++ > > hw/misc/Kconfig | 3 + > > hw/misc/imx8mp_mu.c | 308 > ++++++++++++++++++++++++++++++++++++ > > hw/misc/meson.build | 1 + > > include/hw/arm/fsl-imx8mp.h | 10 ++ > > include/hw/misc/imx8mp_mu.h | 53 +++++++ > > 8 files changed, 416 insertions(+) > > create mode 100644 hw/misc/imx8mp_mu.c > > create mode 100644 include/hw/misc/imx8mp_mu.h > > > > +static void imx8mp_mu_class_init(ObjectClass *oc, const void *data) { > > + DeviceClass *dc = DEVICE_CLASS(oc); > > + > > + device_class_set_legacy_reset(dc, imx8mp_mu_reset); > > No device_class_set_legacy_reset() please. > > (We should really gate it in ./checkpatch.pl). >
Will remove this and use 'resettable interface' instead. Will do the same for GPC and GPR in v2. > > + dc->vmsd = &imx8mp_mu_vmstate; > > + dc->desc = "i.MX 8M Plus Messaging Unit"; }
