Re: [PATCH] crypto: fix client side anonymous TLS credentials

[Michael Tokarev]

On 23.04.2026 16:44, Daniel P. Berrangé wrote:

The previous refactoring of credential creation failed to allocate
storage fo the anonymous TLS credentials on the client endpoint.

Fixes: 70f9fd8dbf7233bee497055a9b7825e3729ce853
Reported-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name>
Signed-off-by: Daniel P. Berrangé <d...@berrange.com>
---
  crypto/tlscredsanon.c               |   2 +
  tests/unit/test-crypto-tlssession.c | 120 +++++++++++++++++++++++++++-
  2 files changed, 121 insertions(+), 1 deletion(-)

diff --git a/crypto/tlscredsanon.c b/crypto/tlscredsanon.c
index 1551382e1f..190c9833a7 100644
--- a/crypto/tlscredsanon.c
+++ b/crypto/tlscredsanon.c
@@ -73,6 +73,8 @@ qcrypto_tls_creds_anon_load(QCryptoTLSCredsAnon *creds,
                                               box->dh_params);
          }
      } else {
+        box = qcrypto_tls_creds_box_new_client(GNUTLS_CRD_ANON);
+
          ret = gnutls_anon_allocate_client_credentials(&box->data.anonclient);

This one feels like a qemu-stable material (11.0.x).
I'm picking it up, please let me know if I shouldn't.

Thanks,

/mjt