On Tue, 26 May 2026 at 15:40, Warner Losh <[email protected]> wrote: > > Great! I look forward to growing this directory.. But I was trying to ask a > slightly > different question: What belongs in user-internal.h? What's the current rubric > for linux-user in that regard?
For linux-user, the user-internals.h header is there because some places outside linux-user/ include qemu.h for various reasons. So (commit 3b249d2661c) I pulled as much as I could that really was only used inside linux-user/ out of linux-user/qemu.h. So it's not so much "what belongs in user-internal.h?" and more "what absolutely has to go in qemu.h and can't be moved elsewhere, because the code outside linux-user needs those definitions?". Some stuff has snuck back into qemu.h again (e.g. the prototype of init_main_thread() could live in user-internals.h but was put in the wrong place) because this kind of "looks like a good place to dump random stuff" header is hard to keep clean. There's probably a better name than "qemu.h" for it. thanks -- PMM
