Re: [PATCH v4 16/21] hw/misc/aspeed_scu: Drop noisy unhandled read logs for AST2700 SCU/SCUIO

[Cédric Le Goater]

On 4/17/26 05:28, Jamin Lin wrote:

The AST2700 SCU/SCUIO read handlers currently emit LOG_GUEST_ERROR
messages for all registers that are not explicitly handled.

However, most SCU registers are simple read-back registers without
side effects, and do not require explicit handling in the read path.
Returning the stored register value is sufficient.

Emitting "Unhandled read" logs for these cases generates excessive
and misleading noise during normal guest operation, making it harder
to spot real issues.

Remove the default unhandled read logging from the SCU and SCUIO read
handlers to reduce log noise and align with common QEMU device model
behavior for passive registers.

Signed-off-by: Jamin Lin <jamin_...@aspeedtech.com>

please send first.

Thanks,

C.

---
  hw/misc/aspeed_scu.c | 14 --------------
  1 file changed, 14 deletions(-)

diff --git a/hw/misc/aspeed_scu.c b/hw/misc/aspeed_scu.c
index 251c23def0..362733ba11 100644
--- a/hw/misc/aspeed_scu.c
+++ b/hw/misc/aspeed_scu.c
@@ -932,13 +932,6 @@ static uint64_t aspeed_ast2700_scu_read(void *opaque, 
hwaddr offset,
          return 0;
      }

- switch (reg) {

-    default:
-        qemu_log_mask(LOG_GUEST_ERROR,
-                      "%s: Unhandled read at offset 0x%" HWADDR_PRIx "\n",
-                      __func__, offset);
-    }
-
      trace_aspeed_ast2700_scu_read(offset, size, s->regs[reg]);
      return s->regs[reg];
  }
@@ -1264,13 +1257,6 @@ static uint64_t aspeed_ast2700_scuio_read(void *opaque, 
hwaddr offset,
          return 0;
      }

- switch (reg) {

-    default:
-        qemu_log_mask(LOG_GUEST_ERROR,
-                      "%s: Unhandled read at offset 0x%" HWADDR_PRIx "\n",
-                      __func__, offset);
-    }
-
      trace_aspeed_ast2700_scuio_read(offset, size, s->regs[reg]);
      return s->regs[reg];
  }