Re: [PATCH v9 14/45] target/arm: Implement BFCVTN for SVE

[Richard Henderson]

On 6/9/26 01:52, Peter Maydell wrote:

On Wed, 3 Jun 2026 at 04:32, Richard Henderson
<richard.hender...@linaro.org> wrote:

Signed-off-by: Richard Henderson <richard.hender...@linaro.org>

diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c
index c47e79637e..eccb5b191c 100644
--- a/target/arm/tcg/translate-sve.c
+++ b/target/arm/tcg/translate-sve.c
@@ -4100,6 +4100,9 @@ TRANS_FEAT_STREAMING_IF(BF1CVTLT, 
aa64_sme2_or_sve2_f8cvt, aa64_sme2,
  TRANS_FEAT_STREAMING_IF(BF2CVTLT, aa64_sme2_or_sve2_f8cvt, aa64_sme2,
                          do_f8cvt, a, gen_helper_sve2_bfcvt, true, true)

+TRANS_FEAT(BFCVTN, aa64_sme2_or_sve2_f8cvt, do_f8cvt,
+           a, gen_helper_sve2_bfcvtn_bh, false, false)

The pseudocode has

if IsFeatureImplemented(FEAT_SME2) then CheckSVEEnabled(); else
CheckNonStreamingSVEEnabled(); end;

so shouldn't this be TRANS_FEAT_STREAMING_IF(..., aa64_sme2, ...) ?

Yep.

r~