On 6/3/26 11:26, Jim MacArthur wrote:
--- a/tests/tcg/aarch64/system/boot.S
+++ b/tests/tcg/aarch64/system/boot.S
@@ -60,6 +60,40 @@ curr_sp0_irq:
  curr_sp0_fiq:
  curr_sp0_serror:
  curr_spx_sync:
+#ifdef ALT_VECTOR_TABLE

This is pretty gpc specific, so "alt" feels too generic. We could probably come up with something generic, but let's wait until we have a second test with which to do so. Perhaps rename to "GPC" for now?

Some asm improvements:

+       sub     sp, sp, #16
+       stp     x0, x1, [sp, #0]

        stp     x0, x1, [sp, -16]!

+       lsr     x0, x0, #26
+       and     x0, x0, #0x3f

        bfxil   x0, x0, #26, #6

+       ldr     x0, =0x1001

        mov     x0, #0x1001

+       ldp     x0, x1, [sp, #0]
+       add     sp, sp, #16

        ldp     x0, x1, [sp], 16

+#ifdef ALT_VECTOR_TABLE
+       .align 12
+       .global exception_log
+       .global exception_fault_address
+       .global exception_type_code
+exception_log:

You don't need to export exception_log.

Slightly better with

        .type exception_fault_address, @object
        .size exception_fault_address, 8

etc, for the 4 symbols being exported.


r~

Reply via email to