On Fri, 5 Jun 2026 at 00:49, Richard Henderson <[email protected]> wrote: > > Signed-off-by: Richard Henderson <[email protected]> > --- > target/arm/tcg/helper-sve-defs.h | 2 ++ > target/arm/tcg/sve_helper.c | 2 ++ > target/arm/tcg/translate-sve.c | 22 +++++++++++++++++----- > target/arm/tcg/sve.decode | 1 - > 4 files changed, 21 insertions(+), 6 deletions(-) > > diff --git a/target/arm/tcg/helper-sve-defs.h > b/target/arm/tcg/helper-sve-defs.h > index 75c0fc919d..11342e1e59 100644 > --- a/target/arm/tcg/helper-sve-defs.h > +++ b/target/arm/tcg/helper-sve-defs.h > @@ -733,6 +733,8 @@ DEF_HELPER_FLAGS_4(sve_trn_s, TCG_CALL_NO_RWG, void, ptr, > ptr, ptr, i32) > DEF_HELPER_FLAGS_4(sve_trn_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) > DEF_HELPER_FLAGS_4(sve2_trn_q, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) > > +DEF_HELPER_FLAGS_4(sve2p2_compact_b, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, > i32) > +DEF_HELPER_FLAGS_4(sve2p2_compact_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, > i32) > DEF_HELPER_FLAGS_4(sve_compact_s, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) > DEF_HELPER_FLAGS_4(sve_compact_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32)
Maybe we don't need the 2p2 suffix in the helper function name? There's no "not-sve2p2 byte/halfword compact" operation we need it to contrast with. Anyway, Reviewed-by: Peter Maydell <[email protected]> thanks -- PMM
