On Tue, 9 Jun 2026 at 12:27, Shameer Kolothum <[email protected]> wrote: > > Hi, > > Changes from v6: > > https://lore.kernel.org/qemu-devel/[email protected]/ > > - Addressed v6 feedback and picked up R-by/T-by tags. Thanks! > - mmap the host VINTF Page0 at IOMMU_VIOMMU_ALLOC instead of on VINTF > enable (patch #14) > - Reset the per-VCMDQ Page0 cache when a queue is freed (patch #19) > - Distributed the reset teardown into the patches that introduce each > resource (patches #18, #21) > - Added a VCMDQ readiness helper and renamed the Page0 backing-pointer > helper to vintf_lvcmdq_ptr() (patches #18, #19) > - Trace the VCMDQ Page0 backing, hw vs cache (patch #19) > - Renamed patch #24 to reflect the changes accurately > - Updated the design and lifecycle documentation (patch #30) > - Based on top of Nathan's "Resolve AUTO properties" v6 series [0]. > > Please find the complete branch here: > https://github.com/shamiali2008/qemu-master/tree/master-vcmdq-v7-ext > > Sanity tested on NVIDIA Grace. Further testing in progress. > > Feedback and testing are very welcome.
> hw/arm/smmuv3-accel.h | 48 ++ > hw/arm/tegra241-cmdqv.h | 384 +++++++++++ > include/hw/arm/smmuv3.h | 3 + > include/hw/arm/virt.h | 1 + > include/system/iommufd.h | 17 +- > include/system/memory.h | 21 + > backends/iommufd.c | 64 ++ > hw/arm/smmuv3-accel-stubs.c | 12 + > hw/arm/smmuv3-accel.c | 194 ++++-- > hw/arm/smmuv3.c | 10 + > hw/arm/tegra241-cmdqv-stubs.c | 16 + > hw/arm/tegra241-cmdqv.c | 1119 +++++++++++++++++++++++++++++++++ > hw/arm/virt-acpi-build.c | 127 ++-- > hw/arm/virt.c | 37 ++ > hw/vfio/iommufd.c | 4 +- > hw/vfio/listener.c | 6 + > system/memory.c | 10 + > backends/trace-events | 4 +- > hw/arm/Kconfig | 5 + > hw/arm/meson.build | 2 + > hw/arm/trace-events | 11 + > hw/vfio/trace-events | 1 + > qemu-options.hx | 8 + > 23 files changed, 2024 insertions(+), 80 deletions(-) > create mode 100644 hw/arm/tegra241-cmdqv.h > create mode 100644 hw/arm/tegra241-cmdqv-stubs.c > create mode 100644 hw/arm/tegra241-cmdqv.c Hi -- I just noticed looking at this diffstat that it does not make any updates to the documentation to describe this new feature. Please could you add something (e.g. to docs/system/arm/virt.rst, or elsewhere if more appropriate) that describes whatever this new thing is and how to use it, in terms that make sense to somebody who isn't deeply immersed in the SMMU and this Nvidia specific bit of hardware ? You can do this as a followup patch, as I've already queued this series. Also, a bullet point for the Changelog giving the short summary of what the new thing is would be nice. This cover letter was too cryptic for me to be able to guess :-) thanks -- PMM
