On 26/06/17 04:50AM, Saif Abrar wrote: > Hello, > This patchset resolves the review comments for v4: > https://lore.kernel.org/qemu-devel/[email protected]/ > > Thanks to all the reviewers for their efforts. > > Major updates include the following: > - Rename to phb5. > - New file for common definitions used in tests/qtest/pnv-* files. > - Initializing PnvPHB4Class members within class_init method. > - Updated IODA3 PCT table max size to 128, each with 2 entries. > - Multiple general cleanups. > > Tested with 'make check-qtest' , 'make check-functional-ppc64' and 'make > check'.
Please don't keep Rbs of people unless explicitly given by them, see: https://www.qemu.org/docs/master/devel/submitting-a-patch.html#proper-use-of-reviewed-by-tags-can-aid-review Generally two things: 1. Rbs are explicitly given (replied to your patch) by person reviewing it. If they reply with Rb on your cover letter, saying it's for the whole series, that Rb can be kept on all patches in the series 2. If you feel your patch has significant changes, generally Rbs are to be removed. Reviewers will be happy to send the Rbs again. I will let other reviewers respond if they disagree. As suggested by Harsh, would be good to rebase it on top of PHB5 patch from jishnu, will help keep PHB5 (P10) and PHB4 (P9) separate. Will be going through the patches. Thanks, - Aditya G
