On Wed, Jun 24, 2026 at 02:15:53PM +0100, Alex Bennée wrote: > Daniel P. Berrangé <[email protected]> writes: > > > With the GitLab mapping files from the previous commit, the > > get_manitainer.pl script is now able to report the gitlab > > handle for each maintainer/reviewer when displaying output. > > > > For example: > > > > $ ./scripts/get_maintainer.pl -f hw/scsi/lsi53c895a.c > > Paolo Bonzini <[email protected]> (supporter:SCSI, gitlab:@bonzini) > > Fam Zheng <[email protected]> (reviewer:SCSI, gitlab:@famzheng) > > [email protected] (open list:All patches CC here) > > I suspect it gets tripped up by utf-8 stuff: > > ➜ ./scripts/get_maintainer.pl -f contrib/gitdm/aliases > "Alex Bennée" <[email protected]> (odd fixer:GIT Data Mining C...) > [email protected] (open list:All patches CC here) > > misses my tag.
The problem turned out to be that we failed to strip the double quotes from the name before doing a lookup. > > However I think this approach is much cleaner. The other option would be > embedding @refs in the M: line: > > M: Alex Bennée <[email protected]> @stsquad My previous version did G: @stsquad but it results in considerable duplication and made automated updates harder. So based on Philippe's suggestion I split it into the map files. > > and letting the script handle it. But I didn't want to hack on > get_maintainer.pl which is why I started playing with a python version. > However I need to add some features to it to reach usable parity with > the perl script. With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
