On Tue, Jul 7, 2026 at 11:08 AM Daniel Henrique Barboza <[email protected]> wrote: > > > > On 7/6/2026 6:08 PM, Pierrick Bouvier wrote: > > On 7/6/2026 9:17 AM, Bin Meng wrote: > >> The OpenSBI firmware build job follows the same pattern as the EDK2 job > >> [1] that was removed earlier [2]: it exists to produce firmware binaries > >> from CI artifacts, but those outputs are not consumed by the tree. > >> > >> Remove the job definition and its project include to avoid maintaining > >> bitrotting container and firmware build logic. > >> > >> [1] 71920809ceab ("gitlab-ci.yml: Add jobs to build EDK2 firmware > >> binaries") > >> [2] 690ceb71936f ("gitlab-ci: Remove job building EDK2 firmware binaries") > >> > >> Signed-off-by: Bin Meng <[email protected]> > >> > >> --- > >> > >> MAINTAINERS | 2 - > >> .gitlab-ci.d/opensbi.yml | 88 --------------------------------- > >> .gitlab-ci.d/opensbi/Dockerfile | 34 ------------- > >> .gitlab-ci.d/qemu-project.yml | 1 - > >> 4 files changed, 125 deletions(-) > >> delete mode 100644 .gitlab-ci.d/opensbi.yml > >> delete mode 100644 .gitlab-ci.d/opensbi/Dockerfile > >> > > > > All good on my side, but let's check with official maintainer and > > reviewer for this file to make sure it's ok. > > > > @Alistair, @Daniel, are you ok with this removal? > > Checking the git log for opensbi.yml this is the most recent commit: > > commit 83aa1baa069c8f77aa9f7d9adfdeb11d90bdf78d > Author: Paolo Bonzini <[email protected]> > Date: Mon Mar 4 13:16:50 2024 -0500 > > gitlab-ci: add manual job to run Coverity > > Add a job that can be run, either manually or on a schedule, to upload > a build to Coverity Scan. The job uses the run-coverity-scan script > in multiple phases of check, download tools and upload, in order to > avoid both wasting time (skip everything if you are above the upload > quota) and avoid filling the log with the progress of downloading > the tools. > > The job is intended to run on a scheduled pipeline run, and scheduled > runs will not get any other job. It requires two variables to be in > GitLab CI, COVERITY_TOKEN and COVERITY_EMAIL. Those are already set up > in qemu-project's configuration as protected and masked variables. > > > I'm not sure what's the actual impact of removing the OpenSBI job would have > with > this Coverity usage. Maybe we don't really care about Coverity downloading > and using > opensbi for whatever Coverity must do and we can remove the job anyway. I > would like > to hear from Alistair and the others about the possible impact first though.
I don't have any insight. I didn't even realise we were doing this as part of the CI. > > > Also, this opensbi job has been around since 2020 and Phil's commit that > removed > the EDK2 job is dated 2023. I'd think that Phil would remove this opensbi > job along > the EDK2 job if the criteria was the same, and yet this job is still here. > Maybe > there's some lore behind it ... Phil, do you remember this stuff? Phil reviewed this change, and the commit that removed EDK2 support says: commit 690ceb71936f9037f6e11580709e26b62d83c17c Author: Philippe Mathieu-Daudé <[email protected]> Date: Fri Mar 10 14:32:47 2023 +0100 gitlab-ci: Remove job building EDK2 firmware binaries When we introduced this Gitlab-CI job in commit 71920809ce ("gitlab-ci.yml: Add jobs to build EDK2 firmware binaries"), the naive plan was to have reproducible binaries by downloading what this job would build, testing it and eventually committing it. With retrospective, nothing happened 3 years later and this job is just bitrotting: So I think we are ok to remove this: Reviewed-by: Alistair Francis <[email protected]> Alistair
