On Mon, Jul 13, 2026 at 01:07:22PM -0700, Matheus Tavares Bernardino wrote: > From: Brian Cain <[email protected]> > > Signed-off-by: Brian Cain <[email protected]> > Signed-off-by: Matheus Tavares Bernardino > <[email protected]> > --- > tests/functional/hexagon/meson.build | 9 ++ > tests/functional/hexagon/test_systests.py | 133 ++++++++++++++++++++++ > tests/functional/meson.build | 1 + > 3 files changed, 143 insertions(+) > create mode 100644 tests/functional/hexagon/meson.build > create mode 100644 tests/functional/hexagon/test_systests.py > > diff --git a/tests/functional/hexagon/meson.build > b/tests/functional/hexagon/meson.build > new file mode 100644 > index 00000000000..6cd684b0df7 > --- /dev/null > +++ b/tests/functional/hexagon/meson.build > @@ -0,0 +1,9 @@ > +# SPDX-License-Identifier: GPL-2.0-or-later > + > +test_hexagon_timeouts = { > + 'systests': 180, > +} > + > +tests_hexagon_system_thorough = [ > + 'systests', > +] > diff --git a/tests/functional/hexagon/test_systests.py > b/tests/functional/hexagon/test_systests.py > new file mode 100644 > index 00000000000..b20b9fc56cc
Test files should have execute permissions. > --- /dev/null > +++ b/tests/functional/hexagon/test_systests.py > @@ -0,0 +1,133 @@ > +#!/usr/bin/env python3 > +# > +# Copyright(c) Qualcomm Innovation Center, Inc. All Rights Reserved. > +# > +# SPDX-License-Identifier: GPL-2.0-or-later > + > +import os > +import re > +import time > +import unittest > + > +from qemu_test import QemuSystemTest, Asset, wait_for_console_pattern > + > + > +_TARBALL_BIN_PATH = os.path.join( > + "systests_standalone_package", > + "StandaloneSysTests_6.4.0.2_v68", > + "bin", > +) Don't use os.path.join to refer to files needed by the test suite - always use one of the helper methods on the QemuBaseTest class.... > + > + > +class SysTestsStandaloneTests(QemuSystemTest): > + SYSTEST_TIMEOUT_SEC = 30 > + > + ASSET_TARBALL = Asset( > + > "https://github.com/qualcomm/qemu-hexagon-testing/releases/download/v0.2.9/systests_standalone.tar.gz";, > + "db961ea3fcc389b478b3d5c2f3bac60bec87e7f3d7efef5e58a9ae8ee78d0e40", > + ) > + > + def setUp(self): > + super().setUp() > + self.archive_extract(self.ASSET_TARBALL) > + self.bin_dir = os.path.join(self.workdir, _TARBALL_BIN_PATH) ...so also skip this... > + self._orig_cwd = os.getcwd() > + os.chdir(self.workdir) > + self.addCleanup(os.chdir, self._orig_cwd) Don't change directory during tests - use properly qualified paths to files. > + > + def tearDown(self): > + if hasattr(self, "_orig_cwd"): > + os.chdir(self._orig_cwd) > + super().tearDown() > + > + def binary(self, name): > + """Return the full path to binary *name* inside bin_dir.""" > + return os.path.join(self.bin_dir, name) This should be just: return self.scratch_file("systests_standalone_package", "StandaloneSysTests_6.4.0.2_v68", "bin", name) > + > + def run_exit_zero(self, binary_name, *extra_args, machine="V66G_1024"): > + """Launch *binary_name* and assert it exits with code 0. > + > + :param binary_name: name of the binary inside bin_dir. > + :param extra_args: optional pairs of (flag, value) strings passed > + to set_vm_arg(), e.g. ('-append', 'myarg'). > + :param machine: QEMU machine type (default "V66G_1024"). > + """ > + self.set_machine(machine) > + self.set_vm_arg("-display", "none") > + self.set_vm_arg("-kernel", self.binary(binary_name)) > + for flag, value in zip(extra_args[::2], extra_args[1::2]): > + self.set_vm_arg(flag, value) > + self.vm.launch() > + self.vm.wait(timeout=60.0) > + self.assertEqual(self.vm.exitcode(), 0, > + f"Test {binary_name} exited with " > + f"code {self.vm.exitcode()}, expected 0") > + > + def run_console_pattern(self, binary_name, pattern, *extra_args, > + machine="V66G_1024"): > + """Launch *binary_name* and wait for *pattern* on the semihosting > console. > + > + :param binary_name: name of the binary inside bin_dir. > + :param pattern: string pattern to wait for via > wait_for_console_pattern. > + :param extra_args: optional pairs of (flag, value) strings passed > + to set_vm_arg(), e.g. ('-append', 'myarg'). > + :param machine: QEMU machine type (default "V66G_1024"). > + """ > + self.set_machine(machine) > + self.set_vm_arg("-display", "none") > + self.set_vm_arg("-kernel", self.binary(binary_name)) > + for flag, value in zip(extra_args[::2], extra_args[1::2]): > + self.set_vm_arg(flag, value) > + self.vm.set_console(semihosting=True) > + self.vm.launch() > + try: > + wait_for_console_pattern(self, pattern) > + finally: > + self.vm.kill() > + > + def test_fopen(self): > + """fopen reads a file passed via --append and verifies its > contents.""" > + with open(os.path.join(self.workdir, "dummy.so"), "w") as f: self.scratch_file("dummy.so") > + f.write("valid\n") > + self.run_exit_zero("fopen", "-append", "dummy.so") How is this working ? You've created a file dummy.so on the host OS, and you're passing a filename "dummy.so" to -append which is a kernel arg. The implication is the kenrel opens this file, but how is the guest kernel accessing the file from the host ?!?!?? > + > + def test_ftrunc(self): > + """ftrunc truncates _testfile_ftrunc from 6 bytes to 1 byte.""" > + ftrunc_path = os.path.join(self.workdir, "_testfile_ftrunc") self.scratch_file("_testfile_ftrunc") > + with open(ftrunc_path, "w") as f: > + f.write("valid\n") > + # Sleep 1 s so mtime change is observable > + time.sleep(1) > + self.run_exit_zero("ftrunc") > + self.assertEqual( > + os.path.getsize(ftrunc_path), > + 1, > + "_testfile_ftrunc should be 1 byte after ftrunc", > + ) > + > + def test_dirent(self): > + """dirent lists a directory passed via --append; output must be > + '. .. fileA fileB'.""" > + dirent_dir = os.path.join(self.workdir, "_dirent_testdir") self.scratch_file("_dirent_testdir") > + os.makedirs(dirent_dir, exist_ok=True) > + open(os.path.join(dirent_dir, "fileA"), "w").close() > + open(os.path.join(dirent_dir, "fileB"), "w").close() self.scratch_file("_dirent_testdir", "fileA") > + self.run_console_pattern( > + "dirent", ". .. fileA fileB", "-append", "_dirent_testdir" Again I'm wondering how the guest OS accesses _dirent_testdir which is a location on the host OS ? > + ) > + > + def test_access(self): > + """access checks R_OK|W_OK on _testfile_access.""" > + with open(os.path.join(self.workdir, "_testfile_access"), "w") as f: > + f.write("valid\n") self.scratch_file("_testfile_access") > + self.run_exit_zero("access") > + > + def test_semihost(self): > + semihost_dir = os.path.join(self.workdir, "_semihost_dir") > + os.makedirs(semihost_dir, exist_ok=True) > + open(os.path.join(semihost_dir, "fileA"), "w").close() > + open(os.path.join(semihost_dir, "fileB"), "w").close() The intermediate dir feels redunddant - why not just create fileA & fileB directly ? ie self.scratch_file("fileA") self.scratch_file("fileB") > + self.run_console_pattern("semihost", "PASS", "-append", "arg1", > "arg2") > + > +if __name__ == "__main__": > + QemuSystemTest.main() > diff --git a/tests/functional/meson.build b/tests/functional/meson.build > index c158197c4b7..c7362dd00ef 100644 > --- a/tests/functional/meson.build > +++ b/tests/functional/meson.build > @@ -14,6 +14,7 @@ subdir('aarch64') > subdir('alpha') > subdir('arm') > subdir('avr') > +subdir('hexagon') > subdir('hppa') > subdir('i386') > subdir('loongarch64') > -- > 2.37.2 > With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
