On Mon, 13 Jul 2026 15:20:29 -0700 Pierrick Bouvier <[email protected]> wrote: > > On 7/13/2026 1:07 PM, Matheus Tavares Bernardino wrote: > > + target_ulong physicalFilenameAddr; > > style: physical_filename_addr; > [...] > > + static const unsigned int mode_table[] = { > [...] > Better to extract this with a static const, and a useful name. > angel_to_host_filemode_table. > [...] > > /* convert ARM ANGEL filemode into host filemode */ > > + if (filemode < 14) { > > Also, compare to sizeof table introduced, or define a constant. > ANGEL_FILEMODE_MAX = 13. > [...] > > + /* > > + * Hexagon's SYS_ISTTY is a bit different than arm's: we do not return > > -1 > > + * on error, neither errno. So we override with out own implementation. > > + */ > > s/out/our > [...] > > + /* > > + * This must match the caller's definition, it would be in the > > + * caller's angel.h or equivalent header. > > + */ > > It would be great to move this definition out of this function also.
Thanks, Pierrick! I'll apply all comments.
