On 20/7/26 21:24, Pierrick Bouvier wrote:
The existing compare function only make sure that we list cpus with PVR
order. However, we never compare cpu names.
As a result, while cpus are grouped per PVR, the order within a group is
non deterministic. Depending on QOM type initialization order, we get
different results for -cpu help.

For instance, previous output could be:
Available CPUs:
   755_v1.0         PVR 00083100
   745_v1.0         PVR 00083100
   755_v1.1         PVR 00083101
   745_v1.1         PVR 00083101

While a sorted output should be:
Available CPUs:
   745_v1.0         PVR 00083100
   755_v1.0         PVR 00083100
   745_v1.1         PVR 00083101
   755_v1.1         PVR 00083101

Fix it by comparing cpu names to have a stable result.
This allows us to record and compare various command line results across
versions to make sure we didn't break anything while working on
single-binary.

Signed-off-by: Pierrick Bouvier <[email protected]>
---
  target/ppc/cpu_init.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Tested-by: Philippe Mathieu-Daudé <[email protected]>

Reply via email to