Connor Kite <[email protected]> writes:
> Add a memory_isolation property to CryptoDevBackendVhostUser and
> add add it as an optional member of CryptodevVhostUserProperties
> in qapi.
>
> This is needed to be able to specify memory isolation for
> cryptodev-vhost-user objects, and the bool will eventually be
> passed to vhost_user_init() in a future patch.
>
> Signed-off-by: Connor Kite <[email protected]>
[...]
> diff --git a/qapi/qom.json b/qapi/qom.json
> index c55776af7d..d7ca1b4203 100644
> --- a/qapi/qom.json
> +++ b/qapi/qom.json
> @@ -350,11 +350,15 @@
> # @chardev: the name of a Unix domain socket character device that
> # connects to the vhost-user server
> #
> +# @memory-isolation: disables access from cryptodev to guest memory.
> +# (default: false)
Want imperative mood and need "since", like this:
# @memory-isolation: disable access from cryptodev to guest memory.
# (default: false) (since 11.2)
Pardon my ignorance... What exactly is "cryptodev" here? Is it code
running in another process?
Should the description answer my question? Perhaps like this:
# @memory-isolation: isolate guest memory. Isolated guest memory
# cannot be accessed from uh, what exactly?
Fill in the blank.
> +#
> # Since: 2.12
> ##
> { 'struct': 'CryptodevVhostUserProperties',
> 'base': 'CryptodevBackendProperties',
> - 'data': { 'chardev': 'str' },
> + 'data': { 'chardev': 'str',
> + '*memory-isolation': 'bool' },
> 'if': 'CONFIG_VHOST_CRYPTO' }
>
> ##
