On 24.07.26 00:30, ConKite wrote:
In support of future work to add a memory isolation mode to vhost-user devices,
a
qdev property, "memory-isolation", is added to all vhost-user devices. This is
simply a bool representing whether the mode is active or not.
Signed-off-by: Connor Kite <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
---
hw/block/vhost-user-blk.c | 1 +
hw/display/vhost-user-gpu.c | 1 +
hw/scsi/vhost-user-scsi.c | 1 +
hw/virtio/vhost-user-base.c | 3 ++-
hw/virtio/vhost-user-fs.c | 1 +
hw/virtio/vhost-user-scmi.c | 1 +
hw/virtio/vhost-user-vsock.c | 1 +
include/hw/virtio/vhost-user-base.h | 1 +
include/hw/virtio/vhost-user-blk.h | 1 +
include/hw/virtio/vhost-user-fs.h | 1 +
include/hw/virtio/vhost-user-scmi.h | 1 +
include/hw/virtio/vhost-user-vsock.h | 1 +
include/hw/virtio/virtio-gpu.h | 1 +
include/hw/virtio/virtio-scsi.h | 1 +
14 files changed, 15 insertions(+), 1 deletion(-)
Should `vhost_user_vga_inst_initfn()` set up an alias for
"memory-isolation", like it does for "chardev" now?
There are four lines in here that the checkpatch script notes to be over
80 characters in length, so they should be broken up.
[...]
diff --git a/hw/virtio/vhost-user-base.c b/hw/virtio/vhost-user-base.c
index 90bd2903db..d2a74a2860 100644
--- a/hw/virtio/vhost-user-base.c
+++ b/hw/virtio/vhost-user-base.c
@@ -409,7 +409,8 @@ static void vub_device_unrealize(DeviceState *dev)
/*Define common qdev properties. Inherited by all children*/
static const Property vub_properties[] = {
- DEFINE_PROP_CHR("chardev", VHostUserBase, chardev)
+ DEFINE_PROP_CHR("chardev", VHostUserBase, chardev),
+ DEFINE_PROP_BOOL("memory-isolation", VHostUserBase, memory_isolation,
false)
Nitpick: I would add a comma here. (This hunk shows specifically why
it’s a good idea: So that future additions don’t have to change the line
to add the comma.)
Hanna
