Hi Flavien,
The code change matches the current AIA requirement: the notice MSI must
be sent after the MRIF update regardless of the interrupt-enable bit.
Andrew's v1 requests to wrap the commit message, retain the notification
comment, and add tests are addressed in v3.
However, the transport corruption reported on v2 is still present in v3.
`b4 am` retrieves 2/3 with this hunk header split:
@@ -788,19 +788,6 @@ static MemTxResult
riscv_iommu_msi_write(RISCVIOMMUState *s,
The continuation has no diff prefix, so both `git apply --check` and
`checkpatch.pl` report a corrupt/line-wrapped patch. Patch 1/3 also has
four similarly wrapped hunk headers, so the posted series cannot be
applied.
For review, I mechanically joined only those five hunk headers. After
that, all three patches pass checkpatch, the riscv64-softmmu build
succeeds, and qtest-riscv64/iommu-riscv-test passes all six subtests,
including both new MRIF notice cases.
Please resend without body reflow (for example with git send-email or
b4 send), and verify the posted copy from lore using `b4 am`. You may
also want to restore Daniel's Reviewed-by from v1, which is missing from
2/3.
With the transport issue fixed, for this patch:
Reviewed-by: Chao Liu <[email protected]>
Tested-by: Chao Liu <[email protected]>
