On 8/16/26 08:17, Philippe Mathieu-Daudé wrote:
diff --git a/target/hexagon/cpu.c b/target/hexagon/cpu.c
index 0ddd898e6e..bfcd9b6159 100644
--- a/target/hexagon/cpu.c
+++ b/target/hexagon/cpu.c
@@ -666,11 +666,13 @@ static const char *access_type_names[] = { "MMU_DATA_LOAD ", "MMU_DATA_STORE",
  static const char *mmu_idx_names[] = { "MMU_USER_IDX", "MMU_GUEST_IDX",
                                         "MMU_KERNEL_IDX" };
-static bool hexagon_tlb_fill(CPUState *cs, vaddr address, int size,
-                             MMUAccessType access_type, int mmu_idx, bool 
probe,
-                             uintptr_t retaddr)
+static bool hexagon_tlb_fill(CPUState *cs, vaddr address,
+                             vaddr first, vaddr last,
+                             MMUAccessType access_type, int mmu_idx,
+                             bool probe, uintptr_t retaddr)
  {
      CPUHexagonState *env = cpu_env(cs);
+    int size = last - address + 1;

Nitpicking, since we know last >= first, could we use size_t instead?
Otherwise:
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>

Certainly I won't change the type in this patch.

It's only used by logging/tracing, so I don't really care, but you may, after 
the fact.


r~

Reply via email to