Hi Oleg,

On Wed, 2026-08-26 at 17:36 +0900, Oleg Endo wrote:
> It seems the implementation of the mac.w / mac.l insn is wrong:
> 
>    mac.w  @Rm+,@Rn+
>    mac.l  @Rm+,@Rn+
> 
> Qemu's implementation first reads both mems, then applies the post-inc.  
> However,
> 
>   mac.w   @R0+,@R0+
> 
> should actually do:
>   read @(R0 + 0)
>   R0 += 2
>   read @(R0 + 2)
>   R0 += 2
> 
> That's also how GDB sh-sim implements it.
> The attached patch fixes it.
> 
> I ran into this issue recently when trying to use qemu for sh4.
> I'm not on the list, so please add me in CC in the reply.

I think the patch should be posted as inline, i.e. using git send-email.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Reply via email to