Hi Philippe
> Subject: Re: [PATCH v3 4/9] hw/arm/aspeed_ast10x0: Remove obsolete
> unimplemented SBC mapping
>
> On 31/8/26 07:57, Philippe Mathieu-Daudé wrote:
> > On 31/8/26 05:41, Jamin Lin wrote:
> >> The AST10x0 SoC now implements the SBC device model. However, the old
> >> unimplemented SBC mapping was left in place.
> >
> > Since the introduction in commit 356b230ed13 ("aspeed/soc : Add
> > AST1030
> > support") indeed.
> >
> >>
> >> Remove the obsolete mapping now that the SBC device is implemented.
> >>
> >> Signed-off-by: Jamin Lin <[email protected]>
> >> ---
> >> hw/arm/aspeed_ast10x0.c | 7 -------
> >> 1 file changed, 7 deletions(-)
> >
> > Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
>
> Please squash:
>
Thanks for the review and suggestion.
Will do.
Jamin
> -- >8 --
> diff --git a/include/hw/arm/aspeed_soc.h b/include/hw/arm/aspeed_soc.h
> index cd68c7f1caa..eb5b9291950 100644
> --- a/include/hw/arm/aspeed_soc.h
> +++ b/include/hw/arm/aspeed_soc.h
> @@ -89,7 +89,6 @@ struct AspeedSoCState {
> AspeedSBCState sbc;
> AspeedSLIState sli;
> AspeedSLIState sliio;
> - UnimplementedDeviceState sbc_unimplemented;
> AspeedSDMCState sdmc;
> AspeedPWMState pwm;
> AspeedWDTState wdt[ASPEED_WDTS_NUM];
> ---
