On 9/3/2026 9:37 AM, Pierrick Bouvier wrote:
> On 9/3/2026 9:34 AM, Pierrick Bouvier wrote:
>> On 9/1/2026 11:22 AM, Pierrick Bouvier wrote:
>>> On 9/1/2026 8:44 AM, Alex Bennée wrote:
>>>> Pierrick Bouvier <[email protected]> writes:
>>>>
>>>>> This series replaces TCG tests makefiles with meson, with the
>>>>> goal of having something more readable and maintainable in the long term.
>>>>> Also it closes the gap that tcg tests had with the rest of tests, by 
>>>>> integrating
>>>>> them with meson directly.
>>>>>
>>>>> It covers all existing tests for all architectures, including
>>>>> user/system/multiarch-user/multiarch-system. It implements all 
>>>>> requirements
>>>>> listed on original thread [1].
>>>>>
>>>>> [1] https://lore.kernel.org/qemu-devel/[email protected]/
>>>>>
>>>> <snip>
>>>>
>>>> I think this series is ready to merge so consider this a final chance to
>>>> review any architecture related bits. I shall generate the PR on Friday.
>>>>
>>>
>>> Glad to hear, thanks Alex.
>>>
>>> Just be aware it does not apply at the moment (since yesterday), because
>>> of armv7 flag added to tcg/arm/Makefile.softmmu-target. You just need to
>>> apply it an anterior commit, and do a git rm to go past the conflict. I
>>> don't think it's worth respining just for it.
>>>
>>> I'll be off next week FYI, so won't be able to help if anything else is
>>> blocking.
>>>
>>> Regards,
>>> Pierrick
>>
>> A new conflict appeared today with latest hexagon PR.
>> If you feel like solving it and adding missing test cases, feel free to
>> do and send the PR.
>>
> 
> For reference, that's the change to add to conflicting commit:
> 
> diff --git a/tests/tcg/hexagon/meson.build b/tests/tcg/hexagon/meson.build
> index aef9a53d773..4a2826c4276 100644
> --- a/tests/tcg/hexagon/meson.build
> +++ b/tests/tcg/hexagon/meson.build
> @@ -49,6 +49,7 @@ tests += {
>    },
>    'invalid-encoding.c': {'cflags': cflags},
>    'invalid-slots.c': {'cflags': cflags},
> +  'icinva.c': {'cflags': cflags},
>    'load_align.c': {'cflags': cflags},
>    'load_unpack.c': {'cflags': cflags},
>    # Build this test with -mv71 to exercise the CABAC instruction
> @@ -60,6 +61,7 @@ tests += {
>    'multi_result.c': {'cflags': cflags},
>    'mem_noshuf.c': {'cflags': cflags},
>    'mem_noshuf_exception.c': {'cflags': cflags},
> +  'privileged-insn.c': {'cflags': cflags},
>    'read_write_overlap.c': {'cflags': cflags},
>    'reg_mut.c': {'cflags': cflags},
>    'scatter_gather.c': {'cflags': [cflags, '-mhvx']},
>

And, please find an updated branch for current series here:
https://github.com/qualcomm/qemu/tree/pbouvier/series/tcg_tests_meson

Regards,
Pierrick

Reply via email to