On Mon, Sep 07, 2026 at 02:26:15PM +0100, Alex Bennée wrote: > Daniel P. Berrangé <[email protected]> writes: > > > This commit changes meson_options.txt, but did not refresh the > > scripts/meson-buildoptions.sh file, so it is sometimes showing > > up dirty when doing a build. > > > > Paolo, I feel like there must be some bug in the logic for triggering > > a rebuild of scripts/meson-buildoptions.sh as contributors frequently > > miss this change. With the current git HEAD, sometimes when I do a > > build it'll refresh the file leaving it dirty, but if I discard all > > local changes and do another build, then it doesn't refresh the file. > > If it is refreshing automatically then should it be in git?
IIUC, there's a chicken and egg problem with this file, since it must exist before 'configure' is run, and thus there is no "build" step yet that could create it. If configure were to call scripts/meson-buildoptions.py on the fly, then it would need to setup the python venv before CLI args are processed which is way too early. With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
