* Markus Armbruster ([email protected]) wrote:
> Fabiano Rosas <[email protected]> writes:
> 
> > The max-bandwidth and avail-switchover-bandwidth parameters are
> > declared as bytes/second in migration.json and interpreted as such
> > throughout the code, except in HMP where they're expected to be
> > provided as mebibytes.
> >
> > Fix the HMP code to parse the values as bytes.
> 
> I wouldn't call this a fix.  The choice of unit was clearly intentional.
> Doesn't mean we must not change it now.  David, what do you think?

Meh I wouldn't worry about whether we call it a 'fix' or not!
The real benefit here is that by making this number consistent
the units in the next patch aren't needed since everyone uses
the same unit.

Dave

> > Signed-off-by: Fabiano Rosas <[email protected]>
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Reply via email to