On 9/11/26 13:42, Simon Scherer wrote:
Mostly yes, but one caveat on "target/i386: clear C1 for all x87 compare
instructions": part of that commit is wrong.
The FCOM/FCOMP/FCOMPP/FUCOM/FUCOMP/FUCOMPP/FICOM/FICOMP part is correct and
hardware-verified. The FCOMI/FCOMIP/FUCOMI/FUCOMIP part is not: the SDM lists
"C1 Set to 0" for those, but real x86-64 hardware leaves C1 unchanged. I
caught this after v2 was posted and sent a v3 dropping these changes
[https://patchew.org/QEMU/[email protected]/],
but
v2 was the version applied.
I'm sending a follow-up fix on top of master now that reverts just the
fcomi/fucomi changes.
Thank you for the explanation. I'll wait for the follow-up patch here.
/mjt
