On 9/14/2026 9:57 AM, Paolo Bonzini wrote:
> On Mon, Sep 14, 2026 at 6:13 PM Pierrick Bouvier
> <[email protected]> wrote:
>> There might be some confusion with what the series introduced. To make
>> it clear, it does not touch, nor use tests/docker/Makefile.include.
>>
>> Each tests/tcg/arch declares which container it depends on, and we have
>> tests/tcg/meson.build that automatically builds it if needed for tests.
>> Reverting that will not be very easy to be honest, as it's a core part
>> of the new logic.
> 
> If it is core, why is it patches 102...105?
> 
>>  > IMHO it would be nice to replace tests/docker/Makefile.include with
>>> a meson.build too. Yes, that would make it rely on a configured
>>> build tree, but IMHO that's an acceptable tradeoff to get more
>>> stuff into meson natively.
>>
>> That's easy, and would allow us to get rid of
>> tests/docker/Makefile.include completely, by adding matching targets
>> make container-image-debian-*. Also, we can have a top target
>> 'container-images'. With this, people can build them with ninja or make.
>>
>> As Daniel mentioned, the trade off is to run configure first, and I feel
>> it's quite acceptable. What do you think Paolo?
> 
> The problem is that right now firmware builds are broken, because all
> the supporting code in configure was removed. I'll review anything
> that fixes it, even moving firmware builds to meson custom_targets
> even though it seems quite intrusive.
>

Moved remaining pc-bios sources to roms, and adapted their Makefile to
make them standalone.

See series here:
https://lore.kernel.org/qemu-devel/[email protected]/T/#

This should fix the current issue Eric had.
Also, if this works fine for you, I'll send another series to fix
linux-user vdso build.

> Paolo
> 

Regards,
Pierrick

Reply via email to