On 9/15/2026 1:09 AM, Richard Henderson wrote:
> On 9/14/26 08:09, Pierrick Bouvier wrote:
>>> If vdso rely on this, we need to keep .mak files for now. They
>>> definitely would deserve to be buildable using meson though.
>>>
>>
>> For vdso, we could simply build them as part of tests/tcg and tcg-tests
>> target, without having tests associated. This way they are always built,
>> and people can update them by simply copying them if needed.
> Why would linux-user depend on tests/tcg/?
>

Currently, vdso build depends on mak generated for tests/tcg, though
it's arguable that it depends on configure, and not tests/tcg/meson.build.

https://gitlab.com/qemu-project/qemu/-/blob/master/linux-user/aarch64/Makefile.vdso?ref_type=heads#L1

No good reason though.

> It seems to me that the cross-compiler infrastructure belongs at top-
> level, not in tests/tcg/, for use by everything else in the tree, vdso
> and roms included.
>

My mistake was definitely to assume it was only used for tests/tcg, and
declare compilers along each arch in tests/tcg:

https://gitlab.com/qemu-project/qemu/-/blob/master/tests/tcg/hppa/meson.build?ref_type=heads#L12

>From Alex message, he will send a revert soon to bring it back top level.

> 
> r~
> 

Regards,
Pierrick

Reply via email to