On Sat, Jul 28, 2012 at 12:14 PM, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 28 July 2012 13:09, Blue Swirl <blauwir...@gmail.com> wrote: >> On Sat, Jul 28, 2012 at 10:57 AM, Peter Maydell >> <peter.mayd...@linaro.org> wrote: >>> On 28 July 2012 10:04, Blue Swirl <blauwir...@gmail.com> wrote: >>>>, I'm getting configure breakage in some cases: >>> >>> The thesis of the patch series is that these represent bugs to be fixed. >> >> Yes, but then the errors should be fixed by the series. When adding >> new GCC warning flags, I also fixed the causes for the warning first. >> Committing known build breakages is not OK. > > I fixed all the ones I saw on my system, obviously. I'll have a look > at this one. > > I think it would be worth committing patches 1-10 now anyway : those fix > configure issues (patch 1 in particular fixes the problem of tests > silently failing when they should pass).
I'm getting this error, probably because now Valgrind support is enabled: CC coroutine-ucontext.o cc1: warnings being treated as errors /src/qemu/coroutine-ucontext.c:204: error: unknown option after '#pragma GCC diagnostic' kind /src/qemu/coroutine-ucontext.c:209: error: unknown option after '#pragma GCC diagnostic' kind Maybe the compiler does not understand this pragma and Valgrind check should also fail in that case. $ gcc -v Using built-in specs. Target: x86_64-linux-gnu Configured with: ../src/configure -v --with-pkgversion='Debian 4.4.5-8' --with-bugurl=file:///usr/share/doc/gcc-4.4/README.Bugs --enable-languages=c,c++,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-4.4 --enable-shared --enable-multiarch --enable-linker-build-id --with-system-zlib --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.4 --libdir=/usr/lib --enable-nls --enable-clocale=gnu --enable-libstdcxx-debug --enable-objc-gc --with-arch-32=i586 --with-tune=generic --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu Thread model: posix gcc version 4.4.5 (Debian 4.4.5-8) > > -- PMM