On 4 August 2012 18:57, Blue Swirl <blauwir...@gmail.com> wrote: > On Sat, Jul 28, 2012 at 1:48 PM, Peter Maydell <peter.mayd...@linaro.org> > wrote: >> On 28 July 2012 13:31, Blue Swirl <blauwir...@gmail.com> wrote: >>> I'm getting this error, probably because now Valgrind support is enabled: >>> CC coroutine-ucontext.o >>> cc1: warnings being treated as errors >>> /src/qemu/coroutine-ucontext.c:204: error: unknown option after >>> '#pragma GCC diagnostic' kind >>> /src/qemu/coroutine-ucontext.c:209: error: unknown option after >>> '#pragma GCC diagnostic' kind >>> >>> Maybe the compiler does not understand this pragma and Valgrind check >>> should also fail in that case. >> >> Yeah, I think this is one of the few tests which want to explicitly >> check "is this construct going to provoke a compiler warning" -- >> fix is for that test to explictly put -Werror in the cflags in >> the compile_prog line. > > Now with your Xen configure patches in place, I'm not getting errors > with this applied except for Clang (which I didn't test earlier). > Maybe this should be applied.
Yes, I think that (assuming we are going to go down this route at all) it would be good to apply this 11/11 patch now in good time before the freeze. Does anybody want to object? thanks -- PMM
