On 09:28 Sun 27 Sep , Philippe Mathieu-Daudé wrote:
> On 26/9/26 11:42, Philippe Mathieu-Daudé wrote:
> > On 26/9/26 11:30, Philippe Mathieu-Daudé wrote:
> > > Cc'ing Luc
> > >
> > > On 25/9/26 12:07, Jonathan Gilbert wrote:
> > > > After each register write handled by cprman_write, function update_mux
> > > > checks each of the clocks to see whether the supplied register index
> > > > applies to it, calling clock_mux_update if so. Each clock has two
> > > > registers, so it needs to check the base cm_offset for CM_CTL and then
> > > > the next slot for CM_DIV. But, it was checking for cm_offset plus 4, as
> > > > though it were a byte offset when it's a logical index.
> > > >
> >
> > Fixes: 7281362484a ("hw/misc/bcm2835_cprman: clock mux skeleton
> > implementation")
> > Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
> >
> > > > Signed-off-by: Jonathan Gilbert <[email protected]>
> > > > ---
> > > > hw/misc/bcm2835_cprman.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Trivial fix so patch queued, thanks.
Thanks for the fix.
A bit late:
Reviewed-by: Luc Michel <[email protected]>
