On 9/30/2026 1:23 PM, Marco Liebel wrote:
On Sat, Sep 26, 2026 at 2:23 PM Brian Cain <[email protected]> wrote:
Signed-off-by: Brian Cain <[email protected]>
---
target/hexagon/mmvec/mmvec.h | 55 ++++++++++++++++++++------------
hw/hexagon/hexagon_hvx_context.c | 5 +++
target/hexagon/hex_common.py | 29 +++++++++++++++++
3 files changed, 68 insertions(+), 21 deletions(-)
/* gvec needs VRegs/QRegs 16-aligned within the struct. */
@@ -26,6 +30,7 @@ static const VMStateDescription vmstate_mmvector = {
.minimum_version_id = 1,
.fields = (const VMStateField[]){
VMSTATE_UINT64_ARRAY(ud, MMVector, MAX_VEC_SIZE_BYTES / 8),
+ VMSTATE_UINT8_ARRAY(ext, MMVector, MAX_VEC_SIZE_BYTES / 4),
VMSTATE_END_OF_LIST()
}
};
Does the version id need to be updated?
yes -ish...
I deliberately omitted it because it seemed like a lot of churn to keep
updating the version IDs among all of the different features impacted
with the upstreaming work going on. I'd hoped/expected I could make a
single update to all of the vmstate-impacted structures for 11.2 rather
than incremental ones each time they changed. Not sure if there's a
best practice here.
