On 10/1/2026 9:07 AM, Pierrick Bouvier wrote:
> On 9/30/2026 11:51 AM, Dominic P wrote:
>> The old Makefile.target built every tests/tcg/i386/*.c. The meson
>> conversion lists the tests explicitly and missed test-i386-opt-shr.c,
>> which 5fe51606146 had added in the meantime, so it is no longer built.
>>
>> Fixes: b4e3e90d61 ("tests/tcg/i386: user tests")
>> Assisted-by: Claude Opus 5 (Anthropic)
>> Signed-off-by: Dominic P <[email protected]>
>> ---
>> tests/tcg/i386/meson.build | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/tests/tcg/i386/meson.build b/tests/tcg/i386/meson.build
>> index 4152371a3f..26bd85c05e 100644
>> --- a/tests/tcg/i386/meson.build
>> +++ b/tests/tcg/i386/meson.build
>> @@ -28,6 +28,7 @@ tests += {
>> 'test-i386-fxtract.c': {},
>> 'test-i386-fyl2x.c': {},
>> 'test-i386-fyl2xp1.c': {},
>> + 'test-i386-opt-shr.c': {},
>> 'test-i386-opt-rol.c': {},
>> 'test-i386-pcmpistri.c': {'cflags': ['-msse4.2']},
>> 'test-i386-pseudo-denormal.c': {},
>
> Thanks Dominic, this indeed has slipped through the cracks.
> I double checked all the rest, and found one missing test for hexagon too.
>
For information, this will unfortunately conflict with current series,
since opt-shr is added after opt-rol.
> I'll pull this patch in upcoming tcg tests PR today.
>
> Regards,
> Pierrick
